TST: Use fixtures in indexes common tests #17622

GuessWhoSamFoo · 2017-09-22T10:51:14Z

closes TST: use fixtures in Index common tests #16835
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Not sure if there is a better way to define fixture params since they're essentially the indexes defined in setup_method. Also thinking about adding an id to each param so the output doesn't look like:

test_base.py::TestMixedIntIndex::test_sort[index0] <- pandas/tests/indexes/common.py PASSED
test_base.py::TestMixedIntIndex::test_sort[index1] <- pandas/tests/indexes/common.py PASSED
test_base.py::TestMixedIntIndex::test_sort[index2] <- pandas/tests/indexes/common.py PASSED
test_base.py::TestMixedIntIndex::test_sort[index3] <- pandas/tests/indexes/common.py PASSED
...

jreback · 2017-09-22T12:03:22Z

pandas/tests/indexes/test_base.py

@@ -29,6 +29,24 @@
 from pandas._libs.lib import Timestamp


+@pytest.fixture(params=[tm.makeUnicodeIndex(100),
+                        tm.makeStringIndex(100),


move these to a conftest.py in this directory then they can be used in any test files

jreback · 2017-09-22T13:05:49Z

pandas/tests/indexes/test_base.py

+@pytest.fixture(params=[tm.makeUnicodeIndex(100),
+                        tm.makeStringIndex(100),
+                        tm.makeDateIndex(100),
+                        tm.makePeriodIndex(100),


you might also want to call the fixture indices to avoid confusion (then in each test that uses you can either rename index -> indices or do a index = indices at the top)

jreback · 2017-09-22T13:08:49Z

pandas/tests/indexes/test_base.py

+                        Index([True, False]),
+                        tm.makeCategoricalIndex(100),
+                        Index([]),
+                        MultiIndex.from_tuples(lzip(


you can name these by:

ids = lambda x: type(x).__name__

jreback · 2017-09-23T20:13:21Z

can you update

jreback · 2017-09-24T12:31:06Z

pandas/conftest.py

+                        tm.makeDateIndex(100),
+                        tm.makePeriodIndex(100),
+                        tm.makeTimedeltaIndex(100),
+                        tm.makeIntIndex(100),


this should work but i was actually meaning a conftest
in the tests/indexes/conftest.py

these put the fixtures close to the testing code

In case this comes up for anyone else, I got confused about the scope of conftest.py until reading this post: https://stackoverflow.com/questions/34466027/in-py-test-what-is-the-use-of-conftest-py-files

pep8speaks · 2017-09-24T22:36:30Z

Hello @GuessWhoSamFoo! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 24, 2017 at 22:38 Hours UTC

codecov · 2017-09-25T02:23:34Z

Codecov Report

Merging #17622 into master will increase coverage by 0.03%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #17622      +/-   ##
==========================================
+ Coverage    91.2%   91.23%   +0.03%     
==========================================
  Files         163      163              
  Lines       49637    49806     +169     
==========================================
+ Hits        45269    45442     +173     
+ Misses       4368     4364       -4

Flag	Coverage Δ
#multiple	`89.03% <92.85%> (+0.06%)`	⬆️
#single	`40.32% <85.71%> (+0.07%)`	⬆️

Impacted Files	Coverage Δ
pandas/tests/indexes/conftest.py	`96.77% <92.85%> (ø)`
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/accessor.py	`93.65% <0%> (-6.35%)`	⬇️
pandas/core/indexes/category.py	`97.74% <0%> (-0.81%)`	⬇️
pandas/core/indexes/interval.py	`92.85% <0%> (-0.72%)`	⬇️
pandas/core/dtypes/common.py	`94.45% <0%> (-0.41%)`	⬇️
pandas/core/categorical.py	`95.28% <0%> (-0.31%)`	⬇️
pandas/io/excel.py	`80.37% <0%> (-0.18%)`	⬇️
pandas/core/frame.py	`97.73% <0%> (-0.14%)`	⬇️
pandas/io/packers.py	`88.19% <0%> (-0.04%)`	⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8276a42...6ea1c70. Read the comment docs.

codecov · 2017-09-25T02:23:37Z

Codecov Report

Merging #17622 into master will increase coverage by 0.03%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #17622      +/-   ##
==========================================
+ Coverage    91.2%   91.23%   +0.03%     
==========================================
  Files         163      163              
  Lines       49637    49806     +169     
==========================================
+ Hits        45269    45442     +173     
+ Misses       4368     4364       -4

Flag	Coverage Δ
#multiple	`89.03% <92.85%> (+0.06%)`	⬆️
#single	`40.32% <85.71%> (+0.07%)`	⬆️

Impacted Files	Coverage Δ
pandas/tests/indexes/conftest.py	`96.77% <92.85%> (ø)`
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/accessor.py	`93.65% <0%> (-6.35%)`	⬇️
pandas/core/indexes/category.py	`97.74% <0%> (-0.81%)`	⬇️
pandas/core/indexes/interval.py	`92.85% <0%> (-0.72%)`	⬇️
pandas/core/dtypes/common.py	`94.45% <0%> (-0.41%)`	⬇️
pandas/core/categorical.py	`95.28% <0%> (-0.31%)`	⬇️
pandas/io/excel.py	`80.37% <0%> (-0.18%)`	⬇️
pandas/core/frame.py	`97.73% <0%> (-0.14%)`	⬇️
pandas/io/packers.py	`88.19% <0%> (-0.04%)`	⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8276a42...6ea1c70. Read the comment docs.

jreback · 2017-09-25T10:21:57Z

thanks!

just added about 1000 tests!

ideally would like to add more local conftests as needed similar to this. IOW there are other places where we need fixtures similar to this. things like timeseries offsets and others, if you are interested.

jreback · 2017-09-25T10:23:01Z

also in pandas/test_base where I think. if you want to search for and make an issue of places to correct would be great (or just send PR's!)

Created fixture with params; removed loops over values()

30d049f

jreback requested changes Sep 22, 2017

View reviewed changes

jreback added the Testing pandas testing functions or related to the test suite label Sep 22, 2017

jreback reviewed Sep 22, 2017

View reviewed changes

GuessWhoSamFoo added 3 commits September 24, 2017 01:44

Added fixtures to conftest; failing test_fast.sh

95b29f7

Only test indices with same type as _holder

5a397b2

Fixed syntax

3e6536b

jreback reviewed Sep 24, 2017

View reviewed changes

Moved new fixture to conftest within test/indexes

30cf0a6

PEP8 blank line fix

6ea1c70

jreback approved these changes Sep 25, 2017

View reviewed changes

jreback added this to the 0.21.0 milestone Sep 25, 2017

jreback merged commit d2b1668 into pandas-dev:master Sep 25, 2017

GuessWhoSamFoo deleted the common_fixtures branch September 28, 2017 03:23

GuessWhoSamFoo mentioned this pull request Oct 9, 2017

TST: Local conftest for test_offsets.py #17825

Merged

3 tasks

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

TST: Use fixtures in indexes common tests (pandas-dev#17622)

e916418

No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

TST: Use fixtures in indexes common tests (pandas-dev#17622)

18fe1e8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Use fixtures in indexes common tests #17622

TST: Use fixtures in indexes common tests #17622

GuessWhoSamFoo commented Sep 22, 2017

jreback Sep 22, 2017

jreback Sep 22, 2017

jreback Sep 22, 2017

jreback commented Sep 23, 2017

jreback Sep 24, 2017

GuessWhoSamFoo Sep 24, 2017

pep8speaks commented Sep 24, 2017 •

edited

Loading

codecov bot commented Sep 25, 2017

codecov bot commented Sep 25, 2017

jreback commented Sep 25, 2017

jreback commented Sep 25, 2017

TST: Use fixtures in indexes common tests #17622

TST: Use fixtures in indexes common tests #17622

Conversation

GuessWhoSamFoo commented Sep 22, 2017

jreback Sep 22, 2017

Choose a reason for hiding this comment

jreback Sep 22, 2017

Choose a reason for hiding this comment

jreback Sep 22, 2017

Choose a reason for hiding this comment

jreback commented Sep 23, 2017

jreback Sep 24, 2017

Choose a reason for hiding this comment

GuessWhoSamFoo Sep 24, 2017

Choose a reason for hiding this comment

pep8speaks commented Sep 24, 2017 • edited Loading

Comment last updated on September 24, 2017 at 22:38 Hours UTC

codecov bot commented Sep 25, 2017

Codecov Report

codecov bot commented Sep 25, 2017

Codecov Report

jreback commented Sep 25, 2017

jreback commented Sep 25, 2017

pep8speaks commented Sep 24, 2017 •

edited

Loading